brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #485: `BundleMaker` utility routines making it easy to...
Date Tue, 14 Feb 2017 17:57:16 GMT
Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-server/pull/485
  
    I think discussion on ML has been 100% supportive of the direction this goes in, with
a lot of ideas of where this could go, and no pushback on the piece part introduced here,
including the REST API.  (I hadn't expected to get it in to the REST API so easily but when
I did I added it to this PR so you are right @aledsage, it does add a usable piece.)
    
    Re minor comments, I'm not in favour of a new module just for this, re a Brooklyn-free
version I don't see the point as this isn't meant as a utility that would be any use outwith
Brooklyn.  Similarly re unit tests for individual tests for methods in `BundleMaker` will
be a lot of work to write and the assertions about the output not what we actually care about
so not worth it, whereas testing them in larger stories gives assurance that it makes bundles
usable from Brooklyn which is what we care about.
    
    Yet to be tested in Karaf mode but if that presents issues can we treat that as a bug
@neykov ?  (I don't know an easy way to test Brooklyn in Karaf mode.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message