brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #480: Config self reference fix
Date Tue, 14 Feb 2017 17:25:01 GMT
Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-server/pull/480
  
    Re `TaskFactory` being a separate PR, that would mean massaging the tests and other places
so there is a clean state where `TF` isn't supported, and a clean state where `TF` is supported.
 Agree in general PRs should be split up, but where something is trivial (integration tests),
or where things are entangled (`TaskFactory`) it should be a judgment call.  We should avoid
hypothetical problem-spotting:  "Your PR includes things not 100% related.  That's scientifically
proven to make it much harder to review."  If in the course of a review it is _actually_ hard,
then ask for a tidy-up.  I might get the balance wrong sometimes but I think here my atrocities
are limited to having neglected #462 for months and months.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message