brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #462: Inherit config default values
Date Tue, 14 Feb 2017 17:04:30 GMT
Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-server/pull/462
  
    @neykov @geomacy @aledsage Done.  Hurrah.  I've fixed the "declared keys" exclusions --
in the end @geomacy's suggestion re cleaning up the `resolveParameters` method was on point,
and the missing case @neykov asked about was guaranteed not to occur, so there are a few other
cleanups also.  Apologies for the complexity of this all (I wish we could move to YOML and
do away with `Entity` subclasses!).  The main new PRs to review are the last two.  The others
are mostly dull fixes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message