brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #480: Config self reference fix
Date Fri, 10 Feb 2017 12:42:59 GMT
Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/480
  
    @ahgittin This is way too hard to review until #462 is merged (which requires rebasing
and a bunch of PR comments to be addressed; as I asked there, will you have time to address
those or would you like one of us to pick it up)?
    
    This PR also looks like it has a bunch of other commits that could (and should) be extracted
into their own PRs (e.g. "solve problem with map eval" perhaps? Definitely "slow tests moved
to integration group"? "cleanup, and allow TaskFactory to be supplied as a config..." perhaps?).
I presume they are not all related to the title "Config self reference fix"?
    
    Including many changes in a single PR makes the reviewers job much harder, and makes it
take much much longer to get things merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message