brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #544: Prefer centos 7
Date Fri, 03 Feb 2017 17:15:52 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/544#discussion_r99381007
  
    --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/BrooklynImageChooser.java
---
    @@ -128,15 +128,18 @@ public double score(Image img) {
     
         
             // prefer these guys, in stock brooklyn provisioning
    -        score += punishmentForOldOsVersions(img, OsFamily.UBUNTU, 11);
    -        score += punishmentForOldOsVersions(img, OsFamily.CENTOS, 6);
     
             OperatingSystem os = img.getOperatingSystem();
             if (os!=null) {
                 if (os.getFamily()!=null) {
                     // preference for these open, popular OS (but only wrt versions above)

    -                if (os.getFamily().equals(OsFamily.CENTOS)) score += 2;
    +                if (os.getFamily().equals(OsFamily.CENTOS)) {
    +                    score += punishmentForOldOsVersions(img, OsFamily.CENTOS, 7);
    +                    score += 3;
    +
    +                }
                     else if (os.getFamily().equals(OsFamily.UBUNTU)) {
    +                    score += punishmentForOldOsVersions(img, OsFamily.UBUNTU, 11);
    --- End diff --
    
    Suggest bumping this to at least 12, ideally 14.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message