Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: neykov <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-529-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-529-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server pull request #529: LocationNetworkInfoCustomizer
Content-Type: text/plain
Message-Id: <20170126150428.38DEADFF9F@git1-us-west.apache.org>
Date: Thu, 26 Jan 2017 15:04:28 +0000 (UTC)
archived-at: Thu, 26 Jan 2017 15:04:31 -0000

Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/529#discussion_r97971034
  
    --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/ManagementAddressResolveOptions.java ---
    @@ -0,0 +1,158 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package org.apache.brooklyn.location.jclouds;
    +
    +import org.apache.brooklyn.util.time.Duration;
    +import org.jclouds.domain.LoginCredentials;
    +
    +import com.google.common.annotations.Beta;
    +import com.google.common.base.Optional;
    +import com.google.common.base.Predicate;
    +import com.google.common.net.HostAndPort;
    +
    +/**
    + * Holds parameters to be used by a {@link LocationNetworkInfoCustomizer}.
    + */
    +@Beta
    +public class ManagementAddressResolveOptions {
    +
    +    private Duration pollTimeout;
    +    private boolean waitForSshable;
    +    private boolean pollForFirstReachableAddress;
    +    private boolean expectReachable;
    +    private boolean isWindows;
    +    private boolean propagatePollForReachableFailure;
    +    private LoginCredentials initialCredentials;
    +    private Optional<LoginCredentials> userCredentials = Optional.absent();
    +    private Optional<HostAndPort> hostAndPortOverride = Optional.absent();
    +    private boolean skipJcloudsSshing;
    +    private boolean publishNetworkSensors = true;
    +    private Predicate<? super HostAndPort> reachableAddressPredicate;
    +
    +    public ManagementAddressResolveOptions expectReachable(boolean expectConnectable) {
    +        this.expectReachable = expectConnectable;
    +        return this;
    +    }
    +
    +    /** Indicate the host and port that should be used over all others. Normally used in tandem with a port forwarder. */
    +    public ManagementAddressResolveOptions hostAndPortOverride(Optional<HostAndPort> hostAndPortOverride) {
    +        this.hostAndPortOverride = hostAndPortOverride;
    +        return this;
    +    }
    +
    +    public ManagementAddressResolveOptions initialCredentials(LoginCredentials initialCredentials) {
    +        this.initialCredentials = initialCredentials;
    +        return this;
    +    }
    +
    +    public ManagementAddressResolveOptions pollForFirstReachableAddress(boolean pollForFirstReachableAddress) {
    +        this.pollForFirstReachableAddress = pollForFirstReachableAddress;
    +        return this;
    +    }
    +
    +    public ManagementAddressResolveOptions propagatePollForReachableFailure(boolean propagatePollForReachableFailure) {
    +        this.propagatePollForReachableFailure = propagatePollForReachableFailure;
    +        return this;
    +    }
    +
    +    public ManagementAddressResolveOptions pollTimeout(Duration pollTimeout) {
    +        this.pollTimeout = pollTimeout;
    +        return this;
    +    }
    +
    +    public ManagementAddressResolveOptions skipJcloudsSshing(boolean skipJcloudsSshing) {
    +        this.skipJcloudsSshing = skipJcloudsSshing;
    +        return this;
    +    }
    +
    +    public ManagementAddressResolveOptions waitForSshable(boolean waitForSshable) {
    +        this.waitForSshable = waitForSshable;
    +        return this;
    +    }
    +
    +    public ManagementAddressResolveOptions isWindows(boolean windows) {
    +        isWindows = windows;
    +        return this;
    +    }
    +
    +    public ManagementAddressResolveOptions userCredentials(Optional<LoginCredentials> userCredentials) {
    +        this.userCredentials = userCredentials;
    +        return this;
    +    }
    +
    +    public ManagementAddressResolveOptions publishNetworks(boolean publishNetworks) {
    --- End diff --
    
    Setter is `publishNetworks`, while getter is `publishNetworkSensor`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---