Return-Path: <dev-return-22214-archive-asf-public=cust-asf.ponee.io@brooklyn.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id AC6D3200C2C
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu, 26 Jan 2017 16:04:30 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id AB0F7160B33; Thu, 26 Jan 2017 15:04:30 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id CA2DF160B62
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 26 Jan 2017 16:04:29 +0100 (CET)
Received: (qmail 62627 invoked by uid 500); 26 Jan 2017 15:04:29 -0000
Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@brooklyn.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@brooklyn.apache.org>
List-Post: <mailto:dev@brooklyn.apache.org>
List-Id: <dev.brooklyn.apache.org>
Reply-To: dev@brooklyn.apache.org
Delivered-To: mailing list dev@brooklyn.apache.org
Received: (qmail 61824 invoked by uid 99); 26 Jan 2017 15:04:28 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Jan 2017 15:04:28 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 38909F403E; Thu, 26 Jan 2017 15:04:28 +0000 (UTC)
From: neykov <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-529-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-529-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server pull request #529: LocationNetworkInfoCustomizer
Content-Type: text/plain
Message-Id: <20170126150428.38909F403E@git1-us-west.apache.org>
Date: Thu, 26 Jan 2017 15:04:28 +0000 (UTC)
archived-at: Thu, 26 Jan 2017 15:04:30 -0000

Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/529#discussion_r97984500
  
    --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java ---
    @@ -625,6 +630,32 @@ public MachineLocation obtain(Map<?,?> flags) throws NoMachinesAvailableExceptio
             }
         }
     
    +    protected ManagementAddressResolveOptions getManagementAddressResolveOptions(
    +            NodeMetadata node, ConfigBag setup, Optional<HostAndPort> sshHostAndPortOverride, Optional<LoginCredentials> userCredentials) {
    +        boolean waitForSshable = !"false".equalsIgnoreCase(setup.get(WAIT_FOR_SSHABLE));
    +        boolean waitForWinRmable = !"false".equalsIgnoreCase(setup.get(WAIT_FOR_WINRM_AVAILABLE));
    +        boolean usePortForwarding = setup.get(USE_PORT_FORWARDING);
    +        boolean skipJcloudsSshing = Boolean.FALSE.equals(setup.get(USE_JCLOUDS_SSH_INIT)) || usePortForwarding;
    +        boolean windows = isWindows(node, setup);
    +        boolean waitForConnectable = windows ? waitForWinRmable : waitForSshable;
    +        String pollForFirstReachable = setup.get(POLL_FOR_FIRST_REACHABLE_ADDRESS);
    --- End diff --
    
    With the reachability check doing credentials check I think `POLL_FOR_FIRST_REACHABLE_ADDRESS` and `WAIT_FOR_XXX_AVAILABLE` pretty much overlap now. Suggest (at the very least) adding a TODO somewhere to deprecate one of them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---