Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: m4rkmckenna <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-519-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-519-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server pull request #519: Add experimental CORS server support
Content-Type: text/plain
Message-Id: <20170118154030.3FB3DDFA70@git1-us-west.apache.org>
Date: Wed, 18 Jan 2017 15:40:30 +0000 (UTC)
archived-at: Wed, 18 Jan 2017 15:40:32 -0000

Github user m4rkmckenna commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/519#discussion_r96662638
  
    --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/filter/CorsImplSupplierFilter.java ---
    @@ -0,0 +1,81 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.brooklyn.rest.filter;
    +
    +import com.google.common.annotations.VisibleForTesting;
    +import com.google.common.base.Preconditions;
    +import com.google.common.reflect.TypeToken;
    +import org.apache.brooklyn.api.mgmt.ManagementContext;
    +import org.apache.brooklyn.config.ConfigKey;
    +import org.apache.brooklyn.core.BrooklynFeatureEnablement;
    +import org.apache.brooklyn.core.config.ConfigKeys;
    +import org.apache.brooklyn.util.JavaGroovyEquivalents;
    +import org.apache.cxf.rs.security.cors.CrossOriginResourceSharingFilter;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import javax.annotation.Nullable;
    +import javax.ws.rs.container.ContainerRequestContext;
    +import javax.ws.rs.container.ContainerResponseContext;
    +import javax.ws.rs.ext.Provider;
    +import java.util.Collections;
    +import java.util.List;
    +
    +/**
    + * @see BrooklynFeatureEnablement#FEATURE_CORS_CXF_PROPERTY
    + */
    +@Provider
    +public class CorsImplSupplierFilter extends CrossOriginResourceSharingFilter {
    +    public static final ConfigKey<List<String>> ALLOWED_ORIGINS = ConfigKeys.newConfigKey(new TypeToken<List<String>>() {},
    +            BrooklynFeatureEnablement.FEATURE_CORS_CXF_PROPERTY + ".allowedOrigins",
    +            "List of allowed origins. Access-Control-Allow-Origin header will be returned to client if Origin header in request is matching exactly a value among the list allowed origins. " +
    +                    "If AllowedOrigins is empty or not specified then all origins are allowed. " +
    +                    "No wildcard allowed origins are supported.",
    +            Collections.<String>emptyList());
    +    private static final Logger LOGGER = LoggerFactory.getLogger(CorsImplSupplierFilter.class);
    +
    +    private static final boolean brooklynFeatureEnabled = BrooklynFeatureEnablement.isEnabled(BrooklynFeatureEnablement.FEATURE_CORS_CXF_PROPERTY);
    +    static {
    +        if (brooklynFeatureEnabled) {
    +            LOGGER.info("CORS brooklyn feature enabled.");
    +        }
    +    }
    +    
    +    @VisibleForTesting
    +    public CorsImplSupplierFilter(@Nullable ManagementContext mgmt) {
    +        setFindResourceMethod(false);
    +        Preconditions.checkNotNull(mgmt,"ManagementContext should be suppplied to CORS filter.");
    +        setAllowOrigins(JavaGroovyEquivalents.<List<String>>elvis(
    +                mgmt.getConfig().getConfig(ALLOWED_ORIGINS), Collections.<String>emptyList()));
    --- End diff --
    
    @bostko Please expose all configuration the filter provides as it is all needed
    
    See https://cxf.apache.org/javadoc/latest/org/apache/cxf/rs/security/cors/CrossOriginResourceSharingFilter.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---