Return-Path: <dev-return-21957-archive-asf-public=cust-asf.ponee.io@brooklyn.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id B63E6200C00
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed, 18 Jan 2017 11:49:25 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id B4C53160B44; Wed, 18 Jan 2017 10:49:25 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id F307E160B3A
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 18 Jan 2017 11:49:24 +0100 (CET)
Received: (qmail 20270 invoked by uid 500); 18 Jan 2017 10:49:24 -0000
Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@brooklyn.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@brooklyn.apache.org>
List-Post: <mailto:dev@brooklyn.apache.org>
List-Id: <dev.brooklyn.apache.org>
Reply-To: dev@brooklyn.apache.org
Delivered-To: mailing list dev@brooklyn.apache.org
Received: (qmail 20259 invoked by uid 99); 18 Jan 2017 10:49:23 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Jan 2017 10:49:23 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id D7D6FDFA70; Wed, 18 Jan 2017 10:49:23 +0000 (UTC)
From: bostko <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-519-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-519-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server pull request #519: Add experimental CORS server support
Content-Type: text/plain
Message-Id: <20170118104923.D7D6FDFA70@git1-us-west.apache.org>
Date: Wed, 18 Jan 2017 10:49:23 +0000 (UTC)
archived-at: Wed, 18 Jan 2017 10:49:25 -0000

Github user bostko commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/519#discussion_r96608079
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/BrooklynFeatureEnablement.java ---
    @@ -61,6 +61,36 @@
         /** whether feeds are automatically registered when set on entities, so that they are persisted */
         public static final String FEATURE_FEED_REGISTRATION_PROPERTY = FEATURE_PROPERTY_PREFIX+".feedRegistration";
     
    +    /**
    +     * <p>
    +     * Enabling CORS is strongly discouraged.
    --- End diff --
    
    I think it is valuable to have more information.
    What others think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---