Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: neykov <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-338-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-338-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server pull request #338: Support nested catalog item definitions -...
Content-Type: text/plain
Message-Id: <20170105131103.1D946DFEE9@git1-us-west.apache.org>
Date: Thu,  5 Jan 2017 13:11:03 +0000 (UTC)
archived-at: Thu, 05 Jan 2017 13:11:05 -0000

Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/338#discussion_r94619869
  
    --- Diff: api/src/main/java/org/apache/brooklyn/api/mgmt/rebind/mementos/Memento.java ---
    @@ -43,11 +44,19 @@
         
         String getId();
         
    -    public String getType();
    -    
    -    public String getCatalogItemId();
    -    
    -    public String getDisplayName();
    +    String getType();
    +
    +    /**
    +     * The principal catalog item id.
    +     */
    +    String getCatalogItemId();
    --- End diff --
    
    This is just for persistence backwards compatibility, right? If so mark it as deprecated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---