brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #521: WIP - AddChildrenEffector has some unexpe...
Date Mon, 16 Jan 2017 20:37:22 GMT
GitHub user ahgittin opened a pull request:

    https://github.com/apache/brooklyn-server/pull/521

    WIP - AddChildrenEffector has some unexpected behaviour wrt DSL and params

    so far just adds tests indicating the ugly behaviour;
    next will:
    * improve impl to avoid the ugly behaviour
    * facilitate evaluation of DSL in configuration parameters

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ahgittin/brooklyn-server tidy-add-children-effector

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/521.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #521
    
----
commit c5806879dfed042a45567699144fc452f899d10d
Author: Alex Heneveld <alex.heneveld@cloudsoftcorp.com>
Date:   2017-01-16T20:34:44Z

    tests indicating current behaviour, including things we don't like

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message