brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #510: Fix logging of creation string in Jclouds...
Date Tue, 10 Jan 2017 11:52:12 GMT
GitHub user sjcorbett opened a pull request:

    https://github.com/apache/brooklyn-server/pull/510

    Fix logging of creation string in JcloudsLocation

    Use `getCreationString` rather than `setup.getDescription` throughout `JcloudsLocation`.

    
    Fixes the annoying nulls in log messages when locations are provisioned:
    ```
    2017-01-10 10:54:17,954 INFO  Creating VM null in JcloudsLocation[...]
    2017-01-10 11:00:34,114 ERROR Failed to start VM for null;
    ```
    etc.
    
    See  8405d8774a0380a99b9dd1fbd2daf7fc15265cb8 for the introduction of `getCreationString`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sjcorbett/brooklyn-server fix/jclouds-description

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/510.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #510
    
----
commit 954fbd580260640816cdd0f4cf86f61185a5f90b
Author: Sam Corbett <sam.corbett@cloudsoftcorp.com>
Date:   2017-01-10T11:33:07Z

    Fix logging of creation string in JcloudsLocation
    
    Commit 8405d8774a0380a99b9dd1fbd2daf7fc15265cb8 switched from setting
    a description on the config bag to providing a `getCreationString`
    method but did not use it throughout the class, meaning several
    statements logged `null`.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message