brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <>
Subject [GitHub] brooklyn-server pull request #531: initial work to support HttpEntity
Date Sun, 29 Jan 2017 20:31:09 GMT
Github user aledsage commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/brooklyn/core/effector/
    @@ -0,0 +1,133 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.brooklyn.core.effector;
    +import java.util.List;
    +import java.util.Map;
    +import javax.annotation.Nullable;
    +import org.apache.brooklyn.api.effector.Effector;
    +import org.apache.brooklyn.api.entity.EntityLocal;
    +import org.apache.brooklyn.config.ConfigKey;
    +import org.apache.brooklyn.core.config.ConfigKeys;
    +import org.apache.brooklyn.core.effector.Effectors.EffectorBuilder;
    +import org.apache.brooklyn.core.entity.EntityInitializers;
    +import org.apache.brooklyn.core.entity.EntityInternal;
    +import org.apache.brooklyn.util.core.config.ConfigBag;
    +import org.apache.brooklyn.util.guava.Maybe;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +public class CompositeEffector extends AddEffector {
    +    private static final Logger LOG = LoggerFactory.getLogger(CompositeEffector.class);
    +    public static final ConfigKey<List<String>> EFFECTORS = ConfigKeys.newConfigKey(new
TypeToken<List<String>>() {}, "effectors",
    --- End diff --
    I see we pass in the same parameters to every effector. I wonder whether we should also
accept a list of maps, so that we could define the parameters to the individual effectors.
But that would make the code more complicated.
    It would be interesting to see what the yaml would look like for that.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message