brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <>
Subject [GitHub] brooklyn-server pull request #539: Log a warning in case of max-concurrency ...
Date Fri, 27 Jan 2017 13:03:47 GMT
Github user neykov commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/brooklyn/core/sensor/ ---
    @@ -56,8 +60,11 @@
             private static class MaxConcurrencyLatch implements ReleaseableLatch {
    +            private static final Logger LOG = LoggerFactory.getLogger(MaxConcurrencyLatch.class);
                 private int permits;
                 private transient final Semaphore sem;
    +            private transient final Set<Entity> ownerEntities = new ConcurrentHashSet<Entity>();
    --- End diff --
    Good spot, haven't considered this case. It's handled and covered by tests though - there's
a `readResolve` further down. Added a comment.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message