brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #539: Log a warning in case of max-concurrency ...
Date Fri, 27 Jan 2017 11:44:47 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/539#discussion_r98187655
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/sensor/ReleaseableLatch.java ---
    @@ -75,7 +89,11 @@ public void acquire(Entity caller) {
     
                 @Override
                 public void release(Entity caller) {
    -                sem.release();
    +                try {
    +                    sem.release();
    +                } finally {
    +                    ownerEntities.remove(caller);
    --- End diff --
    
    I think this is fine. If we wanted to get more complicated, we could use a MultiMap or
some such so that we know how many times the entity has called acquire(). But that doesn't
feel worth the complexity, so I like the code as-is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message