brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #539: Log a warning in case of max-concurrency ...
Date Fri, 27 Jan 2017 11:43:22 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/539#discussion_r98187488
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/sensor/ReleaseableLatch.java ---
    @@ -56,8 +60,11 @@
             }
     
             private static class MaxConcurrencyLatch implements ReleaseableLatch {
    +            private static final Logger LOG = LoggerFactory.getLogger(MaxConcurrencyLatch.class);
    +
                 private int permits;
                 private transient final Semaphore sem;
    +            private transient final Set<Entity> ownerEntities = new ConcurrentHashSet<Entity>();
    --- End diff --
    
    The `transient` makes me think you're trying to handle persistence of the `MaxConcurrencyLatch`
- is that right?
    
    If so, then this will fail after rebind because the field `sem` will be null. We'd need
a readResolve method to set it, or a getter that lazily instantiates the semaphore.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message