brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #539: Log a warning in case of max-concurrency ...
Date Fri, 27 Jan 2017 11:41:49 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/539#discussion_r98187291
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/sensor/ReleaseableLatch.java ---
    @@ -66,6 +73,13 @@ public MaxConcurrencyLatch(int permits) {
     
                 @Override
                 public void acquire(Entity caller) {
    +                if (!ownerEntities.add(caller)) {
    +                    LOG.warn("Entity {} trying to double-acquire permit with ~{} permits
available and ~{} threads waiting in queue",
    --- End diff --
    
    Perhaps change this log message slightly:
    ```
    LOG.warn("Entity {} acquiring permit multiple times with ~{} permits available ...
    ```
    It could otherwise be mis-understood as saying that the entity was trying to do it, but
that it's being skipped.
    
    Worth adding javadoc to say what the semantics are for reentrant calls (and multiple calls
by the same entity from different threads).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message