brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #529: LocationNetworkInfoCustomizer
Date Thu, 26 Jan 2017 15:04:04 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/529#discussion_r97975373
  
    --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
    @@ -1917,15 +1820,18 @@ public JcloudsMachineLocation registerMachine(ConfigBag setup)
throws NoMachines
         protected JcloudsMachineLocation registerMachineLocation(ConfigBag setup, NodeMetadata
node) {
             ComputeService computeService = getComputeService(setup);
             boolean windows = isWindows(node, setup);
    -        
    -        HostAndPort managementHostAndPort = resolveManagementHostAndPort(
    -                node, Optional.<LoginCredentials>absent(), Optional.<HostAndPort>absent(),
setup,
    -                new ResolveOptions()
    -                        .windows(windows)
    -                        .expectConnectable(true)
    -                        .propagatePollForReachableFailure(false)
    -                        .pollForFirstReachableAddress(!"false".equalsIgnoreCase(setup.get(POLL_FOR_FIRST_REACHABLE_ADDRESS))));
    -        
    +
    +        // Not publishing networks since they should have previously been published.
    +        ManagementAddressResolveOptions options = getManagementAddressResolveOptions(
    +                node, setup, Optional.<HostAndPort>absent(), Optional.fromNullable(node.getCredentials()))
    +                .publishNetworks(false);
    --- End diff --
    
    This could be called when adopting and managing a machine created outside of Brooklyn,
correct? If so the entity we are attaching it to won't have the networks published yet.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message