brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #529: LocationNetworkInfoCustomizer
Date Thu, 26 Jan 2017 15:04:04 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/529#discussion_r97966691
  
    --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicTask.java ---
    @@ -377,7 +377,9 @@ public T getUnchecked() {
         public synchronized void blockUntilStarted() {
             blockUntilStarted(null);
         }
    -    
    +
    +    // TODO: This should log a message if timeout is null and the method blocks for an
unreasonably long time -
    +    // it probably means someone called .get() and forgot to submit the task.
    --- End diff --
    
    Should differentiate between not queued to a parent task (because the user forgot the
submit it) and not yet submitted to an executor because a previous task failed which is a
valid case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message