brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #530: JcloudsLocation is not releasing its cust...
Date Wed, 25 Jan 2017 19:46:18 GMT
GitHub user geomacy reopened a pull request:

    https://github.com/apache/brooklyn-server/pull/530

    JcloudsLocation is not releasing its customizers (BROOKLYN-427)

    preRelease and postRelease of JcloudsLocationCustomizers are not being 
    called as expected during the release of a Jclouds machine location.
    The problem is that the "setup" used in JcloudsLocation.obtainOnce includes a copy of
the flags passed from MachineLifecycleEffectorTasks#stopAnyProvisionedMachines,
    which includes the customizers. However, the "setup" used in the "release"
    method of JcloudsLocation is taken from the JcloudsLocation itself, which
    is the provisioning (i.e. parent) location, which doesn't have those 
    customizers in it.
    It would actually make more sense to get the location customizers from
    the machine location, as a given parent could have mutiple machines
    with different customizers.
    
    The changes here include an addition to the
    `JcloudsCustomizerInstantiationYamlDslTest#testCustomizers`
    to demonstrate the problem, and a fix that adds the config to 
    the machine location.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/geomacy/brooklyn-server jclc-release

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/530.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #530
    
----
commit 6fef9147b10cdf24b2b18d9c49ee8076d60c94bd
Author: Geoff Macartney <geoff.macartney@cloudsoftcorp.com>
Date:   2017-01-19T17:10:45Z

    preRelease and postRelease of JcloudsLocationCustomizers are not called on stop

commit 588ef4b97789770cb2fa5c48b267b35cedcc8ae3
Author: Geoff Macartney <geoff.macartney@cloudsoftcorp.com>
Date:   2017-01-19T17:28:31Z

    Fix broken test for preRelease/postRelease

commit 645d59ba4ab3fa85cbf07449dbfaf4a1d0a396c9
Author: Geoff Macartney <geoff.macartney@cloudsoftcorp.com>
Date:   2017-01-25T14:55:54Z

    Add the config for JCLOUDS_LOCATION_CUSTOMIZERS at construction time
    so migrated settings are all at one place.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message