brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #520: Limit parallelism of start/stop steps on ...
Date Wed, 25 Jan 2017 11:21:29 GMT
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/520#discussion_r97757004
  
    --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/lifecycle/MachineLifecycleEffectorTasks.java
---
    @@ -731,15 +774,30 @@ protected void restartChildren(ConfigBag parameters) {
          * If no errors were encountered call {@link #postStopCustom()} at the end.
          */
         public void stop(ConfigBag parameters) {
    -        doStop(parameters, new StopAnyProvisionedMachinesTask());
    +        doStopLatching(parameters, new StopAnyProvisionedMachinesTask());
         }
     
         /**
          * As {@link #stop} but calling {@link #suspendAnyProvisionedMachines} rather than
          * {@link #stopAnyProvisionedMachines}.
          */
         public void suspend(ConfigBag parameters) {
    -        doStop(parameters, new SuspendAnyProvisionedMachinesTask());
    +        doStopLatching(parameters, new SuspendAnyProvisionedMachinesTask());
    +    }
    +
    +    protected void doStopLatching(ConfigBag parameters, Callable<StopMachineDetails<Integer>>
stopTask) {
    --- End diff --
    
    Despite the name, this doesn't actually aquire the latch - that's left to the `doStop`
- see comment on `preStopConfirm` below.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message