brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #529: LocationNetworkInfoCustomizer
Date Mon, 23 Jan 2017 13:51:39 GMT
Github user geomacy commented on the issue:

    https://github.com/apache/brooklyn-server/pull/529
  
    Will have a look through this now, however, on the points for opinion above, my 2ยข worth
is:
    
    - naming: "Customizer" isn't really needed (we don't insist on e.g. VanillaSoftwareProcessEntity),
and this class isn't really "Basic" (which to me refers to the "default no-op" behaviour of
`BasicJcloudsLocationCustomizer`). Also "Location" doesn't add much to the description, when
you already have "Network".  The role of the class is about choosing which network you want,
not really about "Info" as such so how about `org.apache.brooklyn.location.jclouds.NetworkPreference`.
    - what to extend: I suppose another way to look at it is, "if someone changes behaviour
in `BasicJcloudsLocationCustomizer` is that something we would want this to inherit"?   No
strong feeling but I tend to think that we would want that, so it should extend it.
    - `publishNetworks` - I'd say prefer leaving things as separate as possible, so would
suggest leaving that to a separate PR.
    - resolve options - will have a look.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message