brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bostko <>
Subject [GitHub] brooklyn-server pull request #519: Add experimental CORS server support
Date Wed, 18 Jan 2017 14:17:23 GMT
Github user bostko commented on a diff in the pull request:
    --- Diff: rest/rest-server/src/test/java/org/apache/brooklyn/rest/
    @@ -0,0 +1,168 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +import org.apache.brooklyn.api.mgmt.ManagementContext;
    +import org.apache.brooklyn.core.BrooklynFeatureEnablement;
    +import org.apache.brooklyn.core.test.entity.LocalManagementContextForTests;
    +import org.apache.brooklyn.util.http.HttpTool;
    +import org.apache.brooklyn.util.http.HttpToolResponse;
    +import org.apache.http.client.HttpClient;
    +import org.apache.http.client.methods.HttpUriRequest;
    +import org.apache.http.client.methods.RequestBuilder;
    +import org.apache.http.impl.client.HttpClients;
    +import org.testng.annotations.Test;
    +import java.util.List;
    +import static;
    +import static*;
    +import static org.testng.Assert.assertEquals;
    +import static org.testng.Assert.assertNull;
    + * If brooklyn.experimental.feature.corsCxfFeature.allowedOrigins is not supplied then
allowedOrigins will be all domains.
    + */
    +public class CorsFilterLauncherTest extends BrooklynRestApiLauncherTestFixture {
    +    @Test
    +    public void testEnabledCorsSendsBasicAllowResponse() throws IOException {
    +        BrooklynFeatureEnablement.enable(BrooklynFeatureEnablement.FEATURE_CORS_CXF_PROPERTY);
    --- End diff --
    You will save only `BrooklynRestApiLauncher apiLauncher` instantiation.
    I do not think making a big test method will be simpler to read.
    However I welcome suggestions for shortening assertions.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message