brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #519: Add experimental CORS server support
Date Wed, 18 Jan 2017 11:05:22 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/519#discussion_r96610978
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/BrooklynFeatureEnablement.java ---
    @@ -61,6 +61,36 @@
         /** whether feeds are automatically registered when set on entities, so that they
are persisted */
         public static final String FEATURE_FEED_REGISTRATION_PROPERTY = FEATURE_PROPERTY_PREFIX+".feedRegistration";
     
    +    /**
    +     * <p>
    +     * Enabling CORS is strongly discouraged.
    --- End diff --
    
    CORS per se is a good thing. When combined with some other features like basic auth could
be a terrible idea because the credentials need to be shared with all clients. Much easier
for malicious users to extract the credentials from the javascript env and use them any way
they like.
    Basic auth would be the reason why I'd stick to proxy until we get something smarter like
web tokens. 
    
    I like @geomacy's suggestion above, but perhaps with the proxy recommendation added to
it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message