brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #519: Add experimental CORS server support
Date Wed, 18 Jan 2017 10:57:42 GMT
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/519#discussion_r96609558
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/BrooklynFeatureEnablement.java ---
    @@ -61,6 +61,36 @@
         /** whether feeds are automatically registered when set on entities, so that they
are persisted */
         public static final String FEATURE_FEED_REGISTRATION_PROPERTY = FEATURE_PROPERTY_PREFIX+".feedRegistration";
     
    +    /**
    +     * <p>
    +     * Enabling CORS is strongly discouraged.
    --- End diff --
    
    The point is that you can't tell at this level whether CORS is appropriate or not; that's
more an architectural question. Sometimes CORS is a proper solution to a given need to integrate
multiple server backends onto a page in a web application (e.g. with a plugin based web application).
 Sometimes it is a hack to glue in some REST call that you should really be handling server
side.  We can't simply say 'use of CORS is discouraged'.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message