brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #513: Use stripped version of ScriptBytecodeAda...
Date Wed, 11 Jan 2017 10:48:00 GMT
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/513#discussion_r95552960
  
    --- Diff: utils/groovy/src/main/java/org/apache/brooklyn/util/groovy/GroovyJavaMethods.java
---
    @@ -75,6 +76,20 @@
             }
         }
     
    +    /**
    +     * Alternative implementation of {@link ScriptBytecodeAdapter#isCase(Object, Object)}<br>
    +     * Stripped down to work only for caseExpression of type <code>java.lang.Class</code>.<br>
    --- End diff --
    
    If we're OK to do that then do we even need this method? Couldn't we just use instanceof/isAssignableFrom
as appropriate?
    ```java
    if ( job instanceof Callable) {
    ```
    etc?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message