brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From m4rkmckenna <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #510: Fix logging of creation string in Jclouds...
Date Tue, 10 Jan 2017 12:13:11 GMT
Github user m4rkmckenna commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/510#discussion_r95351893
  
    --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
    @@ -651,7 +651,7 @@ protected MachineLocation obtainOnce(ConfigBag setup) throws NoMachinesAvailable
             Stopwatch provisioningStopwatch = Stopwatch.createStarted();
     
             try {
    -            LOG.info("Creating VM "+setup.getDescription()+" in "+this);
    +            LOG.info("Creating VM "+getCreationString(setup)+" in "+this);
    --- End diff --
    
    [minor / ignore] I would change this to  `LOG.info("Creating VM {} in {}", getCreationString(setup),
this);`
    
    probably applies elsewhere


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message