brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tbouron <...@git.apache.org>
Subject [GitHub] brooklyn-dist pull request #75: Use new brooklyn-server-config feature
Date Tue, 10 Jan 2017 10:04:56 GMT
Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-dist/pull/75#discussion_r95332454
  
    --- Diff: karaf/features/src/main/feature/feature.xml ---
    @@ -55,7 +55,12 @@
             <bundle>mvn:javax.annotation/javax.annotation-api/${cxf.javax.annotation-api.version}</bundle>
         </feature>
     
    +    <feature name="brooklyn-config" version="${project.version}">
    --- End diff --
    
    We could but I found it cleaner like this. Also, we may have more than one configuration
features like a `brooklyn-dist-config`, `jetty-config`, etc.
    
    With this structure, we can just add it to `brooklyn-config`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message