brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-dist pull request #75: Use new brooklyn-server-config feature
Date Tue, 10 Jan 2017 09:55:40 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-dist/pull/75#discussion_r95331050
  
    --- Diff: karaf/features/src/main/feature/feature.xml ---
    @@ -55,7 +55,12 @@
             <bundle>mvn:javax.annotation/javax.annotation-api/${cxf.javax.annotation-api.version}</bundle>
         </feature>
     
    +    <feature name="brooklyn-config" version="${project.version}">
    +        <feature>brooklyn-server-config</feature>
    +    </feature>
    +
         <feature name="brooklyn-headless" version="${project.version}" description="All
Brooklyn bundles witht the exception of the launcher">
    +        <feature prerequisite="true">brooklyn-config</feature>
    --- End diff --
    
    Gut feel is that we should move this line to after the feature `brooklyn-guava-optional-deps`.
I think that the "prerequisite" features are resolved/loaded in-order. We presumably want
all of the standard karaf stuff in place before we try installing/starting the `brooklyn-server-config`
feature.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message