brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #508: Alternate names for JcloudsProviders
Date Mon, 09 Jan 2017 13:40:10 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/508#discussion_r95156115
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/persist/DeserializingJcloudsRenamesProvider.java
---
    @@ -0,0 +1,43 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.brooklyn.core.mgmt.persist;
    +
    +import java.util.Arrays;
    +
    +public class DeserializingJcloudsRenamesProvider extends DeserializingProvider{
    +
    +    private static DeserializingJcloudsRenamesProvider instance;
    +
    +    public static DeserializingJcloudsRenamesProvider getInstance(){
    +        if (instance == null) instance = new DeserializingJcloudsRenamesProvider();
    +        return instance;
    +    }
    +
    +    private DeserializingJcloudsRenamesProvider(){
    +        super(Arrays.asList(new ConfigLoader[]{
    --- End diff --
    
    Ah, good point. Given that the super-constructor is protected, then that's ok. Could instead
use: `super(MutableList.of(new JcloudsProviderRenameConfigLoader()));`
    
    As a side-note, if the constructor were public, then it would be better to take a copy
of the list (rather than relying on the caller passing in a mutable list).
    
    If we do continue to rely on the constructor being called with a mutable list (rather
than it taking a copy), then probably worth adding a javadoc comment about that parameter.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message