brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #462: Inherit config default values
Date Fri, 06 Jan 2017 17:42:48 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/462#discussion_r94984001
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigInheritance.java
---
    @@ -82,9 +223,17 @@ public InheritanceMode isInherited(ConfigKey<?> key, Object
from, Object to) {
         
         protected <TContainer, TValue> void checkInheritanceContext(ConfigValueAtContainer<TContainer,
TValue> local, ConfigInheritanceContext context) {
             ConfigInheritance rightInheritance = ConfigInheritances.findInheritance(local,
context, this);
    -        if (!equals(rightInheritance)) 
    +        if (!isSameRootInstanceAs(rightInheritance)) {
                 throw new IllegalStateException("Low level inheritance computation error:
caller should invoke on "+rightInheritance+" "
                     + "(the inheritance at "+local+"), not "+this);
    +        }
    +    }
    +
    +    private boolean isSameRootInstanceAs(ConfigInheritance other) {
    +        if (other==null) return false;
    +        if (this==other) return true;
    +        if (other instanceof DelegatingConfigInheritance) return isSameRootInstanceAs(
((DelegatingConfigInheritance)other).getDelegate() );
    --- End diff --
    
    Another reason to avoid the delegate. Why is `equals` a bad idea?
    Note that you could still end up with an anonymous `BasicConfigInheritance` coming from
persistence - they are not resolved to the singletons.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message