brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <>
Subject [GitHub] brooklyn-server pull request #462: Inherit config default values
Date Fri, 06 Jan 2017 17:42:48 GMT
Github user neykov commented on a diff in the pull request:
    --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/
    @@ -309,7 +298,7 @@ public void testCatalogConfigOverridesParameters() {
             CatalogItem<?, ?> item = catalog.getCatalogItem(SYMBOLIC_NAME, TEST_VERSION);
             AbstractBrooklynObjectSpec<?,?> spec = catalog.peekSpec(item);
             List<SpecParameter<?>> params = spec.getParameters();
    -        assertEquals(params.size(), 3);
    +        assertEquals(params.size(), NUM_ENTITY_DEFAULT_CONFIG_KEYS + 2);
    --- End diff --
    Hmm now that we are merging parameters with config keys I'd expect this should behave
the same as `testRootParametersUnwrapped` (again unrelated to the PR).

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message