brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #338: Support nested catalog item definitions -...
Date Thu, 05 Jan 2017 13:11:03 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/338#discussion_r94617757
  
    --- Diff: api/src/main/java/org/apache/brooklyn/api/internal/AbstractBrooklynObjectSpec.java
---
    @@ -187,7 +202,24 @@ public final String getDisplayName() {
         }
         
         public final String getCatalogItemId() {
    -        return catalogItemId;
    +        if (catalogItemIdStack.size() != 0) {
    +            return catalogItemIdStack.getFirst();
    +        }
    +        return null;
    +    }
    +
    +    /**
    +     * An immutable list of ids of this object's catalog item and its defining catalog
items.
    +     * e.g. if the catalog item is defined as
    +     * <pre>
    +     *     items:
    +     *     - id: X
    +     *       item: Y
    +     * </pre>
    +     * then the list will contain X, Y.
    --- End diff --
    
    Can you add as a clarification something like - wrapping items are first in the list (or
wrapping items precede wrapped items)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message