brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #338: Support nested catalog item definitions -...
Date Thu, 05 Jan 2017 13:10:58 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/338#discussion_r94618943
  
    --- Diff: api/src/main/java/org/apache/brooklyn/api/internal/AbstractBrooklynObjectSpec.java
---
    @@ -99,23 +102,35 @@ public SpecT displayName(String val) {
         }
         
         public SpecT catalogItemId(String val) {
    -        catalogItemId = val;
    +        catalogItemIdStack.clear();
    +        return nestCatalogItemId(val);
    +    }
    +
    +    public SpecT catalogItemIds(List<String> ids) {
    +        catalogItemIdStack.clear();
    +        catalogItemIdStack.addAll(ids);
             return self();
         }
    -    // TODO in many places (callers to this method) we prefer a wrapper item ID;
    -    // that is right, because the wrapper's defn will refer to the wrapped,
    -    // but we might need also to collect the item ID's so that *all* can be searched.
    -    // e.g. if R3 references R2 which references R1 any one of these might supply config
keys 
    -    // referencing resources or types in their local bundles. 
    +
    +    /**
    +     * Adds (stacks) the catalog item id of a wrapping specification.
    +     * Does nothing if the value is null.
    +     *
    +     * Used when we to collect nested item ID's so that *all* can be searched.
    +     * e.g. if R3 references R2 which references R1 any one of these might supply config
keys
    +     * referencing resources or types in their local bundles.
    +     */
         @Beta
    -    public SpecT catalogItemIdIfNotNull(String val) {
    --- End diff --
    
    I'd deprecate it, even if marked as `@Beta`.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message