brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #338: Support nested catalog item definitions -...
Date Thu, 05 Jan 2017 13:10:37 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/338#discussion_r94615424
  
    --- Diff: api/src/main/java/org/apache/brooklyn/api/internal/AbstractBrooklynObjectSpec.java
---
    @@ -99,23 +102,35 @@ public SpecT displayName(String val) {
         }
         
         public SpecT catalogItemId(String val) {
    -        catalogItemId = val;
    +        catalogItemIdStack.clear();
    +        return nestCatalogItemId(val);
    +    }
    +
    +    public SpecT catalogItemIds(List<String> ids) {
    +        catalogItemIdStack.clear();
    +        catalogItemIdStack.addAll(ids);
    --- End diff --
    
    Don't see this used, do you think we should keep it?
    Since catalog items are added in reverse order is it fine to add the list as is, should
it be reversed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message