brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From m4rkmckenna <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #492: Allow a user to add or override deseriali...
Date Wed, 04 Jan 2017 10:18:39 GMT
Github user m4rkmckenna commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/492#discussion_r94558762
  
    --- Diff: karaf/init/pom.xml ---
    @@ -75,7 +75,18 @@
             <extensions>true</extensions>
             <configuration>
               <instructions>
    -            <Import-Package>!org.apache.brooklyn.core.internal.BrooklynProperties.Factory,
*</Import-Package>
    +            <!--
    +                See http://stackoverflow.com/questions/18844987/creating-a-blueprint-bean-from-an-inner-class:
    +                we unfortunately need to exclude DeserializingClassRenamesProvider from
the imports. 
    +                Its inner class is referenced in a bean of blueprint.xml. This confuses
the mvn 
    +                plugin, which would otherwise add it to the Import-Package (thus causing
the bundle
    +                to fail to install).
    +            -->
    +            <Import-Package>
    +                !org.apache.brooklyn.core.internal.BrooklynProperties.Factory, 
    +                !org.apache.brooklyn.core.mgmt.persist.DeserializingClassRenamesProvider,
    --- End diff --
    
    Agree OSGi / internal classes are usually a bad idea


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message