Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: geomacy <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-492-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-492-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server issue #492: Allow a user to add or override deserialize conf...
Content-Type: text/plain
Message-Id: <20161220235134.5F728DFB85@git1-us-west.apache.org>
Date: Tue, 20 Dec 2016 23:51:34 +0000 (UTC)
archived-at: Tue, 20 Dec 2016 23:51:36 -0000

Github user geomacy commented on the issue:

    https://github.com/apache/brooklyn-server/pull/492
  
    hi @svet, @tbouron, the `ConfigurationAdmin` is an OSGI compendium service, is that a dependency that we'd be happy to add to brooklyn-core?  I think I would prefer not to, but if so , then we could get config admin from a static context as @neykov says. On the other hand we could avoid the compendium dependency, and instead change the `DeserializingClassRenamesProvider` class to become a non-static provider - it could be a singleton object that gets set up in the launchers (with an appropriate implementation, one way for OSGI launcher, one way for classic), probably in the `initPersistence` stage.  After that, then 
    `DeserializingClassRenamesProvider.loadDeserializingClassRenames()`
    becomes 
    `DeserializingClassRenamesProvider.INSTANCE.loadDeserializingClassRenames()`
    
    Just a thought!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---