Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: ahgittin <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-132-brooklyn-docs@git.apache.org>
In-Reply-To: <git-pr-132-brooklyn-docs@git.apache.org>
Subject: [GitHub] brooklyn-docs pull request #132: Using Bundle-SymbolicName in Catalog
Content-Type: text/plain
Message-Id: <20161212171035.28E9CE9411@git1-us-west.apache.org>
Date: Mon, 12 Dec 2016 17:10:35 +0000 (UTC)
archived-at: Mon, 12 Dec 2016 17:10:37 -0000

Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-docs/pull/132#discussion_r91992440
  
    --- Diff: guide/ops/catalog/index.md ---
    @@ -161,6 +167,30 @@ The following optional catalog metadata is supported:
       whenever a bundle is reloaded in a Brooklyn server,
       and if entities have been deployed against that version, their behavior may change in subtle or potentially incompatible ways.
       To avoid this situation, it is highly recommended to use OSGi version stamps as part of the URL.
    +- To refer a resource from a JAR file added by brooklyn.libraries 
    +  you should include OSGi Bundle-SymbolicName in the classpath.
    +  Example:
    +  
    +~~~ yaml
    +brooklyn.catalog:
    +  brooklyn.libraries:
    +  - url: http://some.server.or.other/path/my.jar
    +    name: myJar-BundleSymbolicName
    +    version: 1.0
    +  items:
    +  - classpath://myJar-BundleSymbolicName:my-catalog-entries-inside-jar.bom
    +  - id: use-from-my-catalog
    +    version: "1.0.0"
    +    itemType: entity
    +    iconUrl: classpath://myJar-BundleSymbolicName:org/apache/brooklyn/MyEntity/icon.png
    +    item:
    +      type: myJar-BundleSymbolicName:org.apache.brooklyn.MyEntity
    +      brooklyn.config:
    +        some.config: "some value"
    +        templates.install:
    +          classpath://myJar-BundleSymbolicName:org/apache/brooklyn/MyEntity/config.xml: config.xml 
    --- End diff --
    
    i've just put together a wee test in https://github.com/apache/brooklyn-server/pull/485 ... classpath resolution seems good for the most part
    
    so tidy this line, and lines 181 and 185
    
    (though we may need a fix to make 185 work, using the right `ResourceUtils` to load the `iconUrl`)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---