Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: ahgittin <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-472-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-472-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server issue #472: Revert 5377839: Replace MultimapSerializer with ...
Content-Type: text/plain
Message-Id: <20161201113842.DDC5ADFC47@git1-us-west.apache.org>
Date: Thu,  1 Dec 2016 11:38:42 +0000 (UTC)
archived-at: Thu, 01 Dec 2016 11:38:45 -0000

Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-server/pull/472
  
    @bostko is there a reason you didn't `git revert` this?  (looks like the commit is not a strict reversion as it adds new tests.)
    
    @neykov good summary of the problems.  agree having the same guava version is an obvious improvement, but sounds like there will continue to be issues afterwards.
    
    unless there is an easy fix where we can continue to deserialize the old format whilst also being able to serialize and deserialize the new format (which sounds like a lot of work, unless the `GuavaModule` supports it as an option), i'd be inclined _not_ to try to get this working and focus instead on restricting serialization/deserialization to explicitly registered types, ideally using yoml, and defining our own YOML serialization rules for those cases where we really need to serialize a guava type.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---