brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #489: BROOKLYN-409: add test
Date Wed, 14 Dec 2016 13:14:15 GMT
GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/489

    BROOKLYN-409: add test

    Includes new osgi test bundle with prefix "com.example.brooklyn"
    
    Without that new osgi bundle, the test might only pass because of the "white-listing"
of org.apache.brooklyn prefixes. As the comment in the relevant pom.xml says, it's ok to use
this mavenId that we don't own because the artifact is only used for test purposes. It is
never part of a release.
    
    ---
    For BROOKLYN-409, this test shows that it is already fixed in master! I believe it was
fixed in this commit:
    ```
    commit a72d1f20ed78504a9b690df1467465b781ac917a
    Author: Aled Sage <aled.sage@gmail.com>
    Date:   Mon Nov 7 17:11:45 2016 +0000
    
        BROOKLYN-379: entity type includes OSGi prefix
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server BROOKLYN-409

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/489.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #489
    
----
commit c0fe24db75ad8b5d664490420997b38db4e3d64c
Author: Aled Sage <aled.sage@gmail.com>
Date:   2016-12-14T11:30:24Z

    BROOKLYN-409: add test
    
    Includes new osgi test bundle with prefix "com.example.brooklyn"

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message