brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #492: Allow a user to add or override deserialize conf...
Date Thu, 22 Dec 2016 23:23:36 GMT
Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/492
  
    Thanks @tbouron Failing test `DslYamlTest.testDslAttributeWhenReady` looks unrelated (we
should look into that in a separate PR). You can kick off jenkins again by running `git commit
--amend; git push --force`.
    
    @m4rkmckenna's right that `org.osgi.service.cm` version should be parameterised. You could
do that here, or we can do it in a separate PR - let me know what you'd prefer.
    
    If you don't get a chance to kick off jenkins again, then I'll try to check out your branch
and run the tests - and then merge (but don't have time to do that just now).
    
    For any other reviewers, note that https://github.com/apache/brooklyn-dist/pull/72 should
be reviewed + tested + merged after this PR is merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message