brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #492: Allow a user to add or override deseriali...
Date Thu, 22 Dec 2016 12:39:10 GMT
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/492#discussion_r93615807
  
    --- Diff: karaf/init/src/main/java/org/apache/brooklyn/launcher/osgi/OsgiLauncher.java
---
    @@ -199,4 +199,7 @@ public void setLocalBrooklynProperties(String localBrooklynProperties)
{
             this.localBrooklynProperties = localBrooklynProperties;
         }
     
    +    public void setDeserializingClassRenamesProvider(DeserializingClassRenamesProvider.OsgiConfigLoader
val) {
    --- End diff --
    
    No, I'd remove the property, since it's a no-op in the Java code it's not needed. (ie.
remove it from both the blueprint.xml and the Java code)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message