brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <>
Subject [GitHub] brooklyn-server pull request #491: (WIP) execAsync parameter for SshMachineL...
Date Fri, 16 Dec 2016 15:54:48 GMT
Github user neykov commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/brooklyn/util/core/internal/ssh/sshj/
    @@ -575,9 +585,16 @@ public int execCommands(Map<String,?> props, List<String>
commands, Map<String,?
             // If async is set, then do it as execScript
    -        Boolean execAsync = getOptionalVal(props, PROP_EXEC_ASYNC);
    +        Boolean execAsync = getOptionalVal(props, PROP_EXEC_ASYNC, this.execAsync);
             if (Boolean.TRUE.equals(execAsync) && BrooklynFeatureEnablement.isEnabled(BrooklynFeatureEnablement.FEATURE_SSH_ASYNC_EXEC))
    -            return execScriptAsyncAndPoll(props, commands, env);
    +            if (!props.containsKey(PROP_EXEC_ASYNC_POLLING_TIMEOUT.getName())) {
    +                return execScriptAsyncAndPoll(
    +                        MutableMap.<String, Object>builder().putAll(props).put(PROP_EXEC_ASYNC_POLLING_TIMEOUT.getName(),
    --- End diff --
    I'd pass `props` as is here and change [this line](
to use `SshjTool.this.execAsyncPollingTimeout` as the default. And fall back to `FIVE_MINUTES`
if null.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message