brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tbouron <>
Subject [GitHub] brooklyn-server pull request #492: Allow a user to add or override deseriali...
Date Thu, 15 Dec 2016 16:28:03 GMT
Github user tbouron commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/persist/
    @@ -72,7 +81,7 @@
                 } finally {
    -        } else {
    +        } catch (Exception e) {
    --- End diff --
    This one is safe. It is for the `new ResourceUtils(DeserializingClassRenamesProvider.class).getResourceFromUrl(url);`
    As per as the javadoc:
    > Takes a string which is treated as a URL (with some extended "schemes" also expected),
or as a path to something either on the classpath (absolute only) or the local filesystem
(relative or absolute, depending on leading slash)
    URLs can be of the form classpath://com/acme/ as well as file:///home/...
    **Throws exception if not found**, using the context parameter passed into the constructor.
    TODO may want OSGi, or typed object; should consider pax url
    a stream, or throws exception **(never returns null)**

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message