brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From m4rkmckenna <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #492: Allow a user to add or override deseriali...
Date Thu, 15 Dec 2016 15:04:53 GMT
Github user m4rkmckenna commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/492#discussion_r92625798
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/persist/DeserializingClassRenamesProvider.java
---
    @@ -54,12 +55,20 @@
         }
         
         private static Map<String, String> loadDeserializingClassRenamesCache() {
    -        InputStream resource = new ResourceUtils(DeserializingClassRenamesProvider.class).getResourceFromUrl(DESERIALIZING_CLASS_RENAMES_PROPERTIES_PATH);
    -        if (resource != null) {
    +        return ImmutableMap.<String, String>builder()
    +                .putAll(loadDeserializingClassRenamesCacheFromUrl(DESERIALIZING_CLASS_RENAMES_PROPERTIES_PATH))
    +                .putAll(loadDeserializingClassRenamesCacheFromUrl(KARAF_DESERIALIZING_CLASS_RENAMES_PROPERTIES_PATH))
    +                .build();
    +    }
    +
    --- End diff --
    
    Didn't spot the static class 
    
    This is probably fine for now  ... When we move to karaf exclusively anything that needs
config should be getting it from config admin


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message