brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #488: Get ready for compiling with JDK 1.8
Date Tue, 13 Dec 2016 21:09:42 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/488#discussion_r92266653
  
    --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java
---
    @@ -486,8 +486,8 @@ public DslConfigSupplier(DslComponent component, String keyName) {
                 if (targetEntityMaybe.isAbsent()) return Maybe.absent("Target entity not
available");
                 EntityInternal targetEntity = (EntityInternal) targetEntityMaybe.get();
     
    -            ConfigKey<?> key = targetEntity.getEntityType().getConfigKey(keyName);
    -            Maybe<? extends Object> result = targetEntity.config().getNonBlocking(key
!= null ? key : ConfigKeys.newConfigKey(Object.class, keyName));
    +            ConfigKey key = targetEntity.getEntityType().getConfigKey(keyName);
    --- End diff --
    
    Seems a shame to have to strip off the generics. Same below.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message