brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #462: Inherit config default values
Date Fri, 02 Dec 2016 00:44:28 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/462#discussion_r90568746
  
    --- Diff: core/src/main/java/org/apache/brooklyn/util/core/xstream/ClassRenamingMapper.java
---
    @@ -42,7 +42,7 @@ public ClassRenamingMapper(Mapper wrapped, Map<String, String>
nameToType) {
         
         @Override
         public Class<?> realClass(String elementName) {
    -        Optional<String> elementNameOpt = Reflections.tryFindMappedName(nameToType,
elementName);
    +        Maybe<String> elementNameOpt = Reflections.findMappedNameMaybe(nameToType,
elementName);
    --- End diff --
    
    the Maybe.absent() contains a useful error message. the Optional.absent() was completely
unhelpful.
    
    re null i don't know whether null is valid or not ... and nor do i need to, i don't think
-- it's not our responsibility here (delegating the rename to the super) to check whether
the rename method gave us the right thing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message