brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <>
Subject [GitHub] brooklyn-library pull request #72: Fix test to work on any combination of OS...
Date Tue, 01 Nov 2016 17:14:47 GMT
GitHub user neykov opened a pull request:

    Fix test to work on any combination of OS & eol type.

    Change line endings for generated script as it's most likely to run in a unix environment.
    Normalize line endings when comparing scripts to work with any combination of OS &
line endings (for tests running on Windows mostly). On Windows you can have both CRLF or LF
line endings in the files (or even mixed), depending on how git is configured. That's out
of our control so try to support any environment.
    The recommended confgiuration is "git --global core.autocrlf true", but Apache Jenkins
machines have "core.autocrlf" set to "input". The former will lead to CRLF line endings, the
latter to LF line endings on checkout.

You can merge this pull request into a Git repository by running:

    $ git pull fix/windows-eol-test

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #72


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message