brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #454: LocalEntityManager: make fields private
Date Tue, 22 Nov 2016 20:23:31 GMT
GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/454

    LocalEntityManager: make fields private

    As discussed with @geomacy in https://github.com/apache/brooklyn-server/pull/453#discussion_r89106124
...
    
    Making these fields non-private is asking for trouble - it makes it
    harder to reason about what the class does and whether it’s safe,
    particularly around thread safety etc.
        
    It is also exposing more implementation detail than is required, making
    refactoring harder in the future.
        
    If there is a compelling reason to provide access to the fields,
    we can consider adding accessor(s).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server LocalManagementContext-fields-private

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/454.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #454
    
----
commit c24cddd51c11d638208633f05de88bf0fd675cc1
Author: Aled Sage <aled.sage@gmail.com>
Date:   2016-11-22T20:18:19Z

    LocalEntityManager: make fields private
    
    Making these fields non-private is asking for trouble - it makes it 
    harder to reason about what the class does and whether it’s safe, 
    particularly around thread safety etc.
    
    It is also exposing more implementation detail than is required, making
    refactoring harder in the future.
    
    If there is a compelling reason to provide access to the fields,
    we can consider adding accessor(s).

commit 06a19507a3f3bf0c2fcd739ca193b4aca59c9ccb
Author: Aled Sage <aled.sage@gmail.com>
Date:   2016-11-22T20:21:38Z

    Add `GroupSupportInternal EntityInternal.groups()`
    
    Remove use of deprecated entity.addGroup/removeGroup()

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message