brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #444: BROOKLYN-396: test and fix
Date Fri, 18 Nov 2016 16:10:06 GMT
GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/444

    BROOKLYN-396: test and fix

    When rebinding a location, if a config flag corresponds to a field
    with `@SetFromFlag` then just set the field, and don’t leave the 
    key-value inside `config().getBag()`.
    
    Some classes use fields to store internal state, which should not be
    passed to child locations (e.g. `LocalhostMachineProvisioningLocation.origConfigs`).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server BROOKLYN-396

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/444.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #444
    
----
commit 3563d4794064b2c2eecf516d7fb96c7e1556e478
Author: Aled Sage <aled.sage@gmail.com>
Date:   2016-11-18T16:07:53Z

    BROOKLYN-396: test and fix
    
    When rebinding a location, if a config flag corresponds to a field
    with “@SetFromFlag” then just set the field, and don’t leave the 
    key-value inside “config().getBag()”.
    
    Some classes use fields to store internal state, which should not be
    passed to child locations
    (e.g. `LocalhostMachineProvisioningLocation.origConfigs`).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message